Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=768894 Alec Leamas <leamas.alec@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |leamas.alec@xxxxxxxxx --- Comment #7 from Alec Leamas <leamas.alec@xxxxxxxxx> 2012-02-23 06:24:17 EST --- No, I'm no reviewer. Still, I have some remarks and questions: The upstream version is 0.0.2, whereas the specfile's version is 0_0_2, indirectly set using a macro. Basically, the Version: tag should reflect the upstream version i. e. "Version: 0.0.2". Note that from that point an implicit %{version} macro is defined, which you can use to derive 0_0_2 which is used in many places. The "%global _configure ../../configure" macro is not used and can be removed. The %{__mkdir_p} type of macros are not used in Fedora, plain 'mkdir -p' is fine See http://fedoraproject.org/wiki/Packaging:Guidelines#macros The source seems to be GPLv3 or later i. e., "License: GPLv3+" ? Backup software is sensitive... Maybe you should enable PIE? See http://fedoraproject.org/wiki/Packaging:Guidelines#PIE Why have you called the desktop file ghaven.desktop? The normal convention is to use the package name i. e., haven.desktop or haven-gtk.desktop? The same question applies to the icons. In the %files section, you have entries like %{_mandir}/man1/haven.1.gz. These are better written %{_mandir}/man1/*, partly for simplicity, partly because the .gz suffix might change in the future. Since the %check target is empty, you might as well remove it. You have a configure-without-libdir-spec warning. Add --libdir=%{_libdir} to the configure calls so that configure knows where to install (lib/lib64). You have an empty-debuginfo-package rpmlint warning. This might be because of the install-strip targets used, if they indeed strip the code. Basically, you should not strip the code but instead build it with debugging enabled. rpmbuild strips it while postprocessing, using the debuginfo in the debug package. Hope this helps, --a -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review