Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772608 --- Comment #17 from Gal Hammer <ghammer@xxxxxxxxxx> 2012-02-22 04:50:41 EST --- (In reply to comment #14) > That sounds weird, and actually sounds like a shortcoming of the GDM plugin > framework and/or the gdm-devel package. I'd still say this is not permisible, > but I'll leave the decision to a more seasoned packager (Steven?) AFAIK, there is no devel package to support GDM plugins development. > From that wiki page: "There are several cases where upstream is not providing > the source to you in an upstream tarball. In these cases you must document how > to generate the tarball used in the rpm either through a spec file comment or a > script included as a separate SourceX" > > Check that URL I pasted above again, you should actually describe how to create > that tarball from git, not point to the tarball you created Since I'm providing the source as a tarball there is not reason to describe how to create that tarball. That's what the quote say. > Try following Steven's advice and bump the rpm changelog every time you make > changes (hint: rpmdev-bumpspec foo.spec). Also try submitting a koji scratch > build (https://fedoraproject.org/wiki/Using_the_Koji_build_system) and paste > the URL each time. In this case I just submitted it and the results are here: > http://koji.fedoraproject.org/koji/taskinfo?taskID=3767959 > As you can see, there are still some unmet build dependencies: > error: Failed build dependencies: > xorg-x11-server-Xorg is needed by gdm-1:3.2.1.1-6.fc17.x86_64 > If you don't want to use koji you can use mock in your machine like this: mock > -r fedora-16-x86_64 rebuild package-1.2-3.src.rpm. This should do a scratch > build in a sanboxed chroot so you can see if all dependencies are met. I'm not using koji at the moment. I've checked the new version (1.0.1-2) using a mock build on my local machine and it worked. I hope this is enough for koji too. > I was just pointing out the python packaging guidelines. Understood. However it would be nice to understand the rational behind it. > I don't think I quite understand this last one... what does "assigned" mean? If > I do in my system (before installing this package) `/usr/sbin/useradd -u 175 -o > -r haproxy -c "High Availability Proxy Daemon User" -d / -s /sbin/nologin` and > then try installing this package, the %prep step would likely fail, I think? Check the file /usr/share/doc/setup-2.8.36/uidgid (from the setup pacakge). It include the "reserved" uids. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review