Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=791263 --- Comment #15 from Alexander Kurtakov <akurtako@xxxxxxxxxx> 2012-02-22 02:28:01 EST --- (In reply to comment #9) > Thanks Alexander for the review! I fixed the Issues you mentioned and uploaded > a new package: > > SPEC: http://icedrobot.de/~roman/mockito/2/mockito.spec > SRPM: http://icedrobot.de/~roman/mockito/2/mockito-1.9.0-2.fc16.src.rpm > Thanks for fixing the issues. It looks good now. > I also have a number of additional questions: > - The included Maven pom is lacking a bunch of dependencies: > - cglib (and maybe asm) because upstream repackages and includes them in > their own JAR. You definetely have to add cglib but I think that asm should not be there as the asm package is version 1.x while cglib is built against package objectweb-asm (version 3.x). If you think that cglib must Require objectweb-asm please open a bug against cglib for that. About cglib not shipping pom I see /usr/share/maven-poms/JPP-cglib.pom is shipped with it. > - JUnit4 because users of Mockito certainly must include that otherwise > Mockito doesn't make sense. >From the rest of the comments it looks like this is optional dependency. As RPM is not supporting soft dependencies I think that the package maintainer (you Roman) is the one to decide whether to add this require or not. Once the cglib dependency is added to the pom I'll approve. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review