Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=794985 --- Comment #5 from Alec Leamas <leamas.alec@xxxxxxxxx> 2012-02-21 13:34:12 EST --- (In reply to comment #2) [cut] > Issues: > FIX: Don't depend directly on perl packages, use the 'perl(Module::Name)' > syntax instead. Remove all your perl-* BuildRequires. Done > FIX: Make sure you BuildRequire the following: [cut] Done > TIP: The number of spaces between your email and version in the changelog > header is a bit weird. Is there a reason for this? I keep them right-adjusted to make them stand out when the comment lines grow longer. It's just a habit, I can adjust you think it's a bad one. > TODO: Drop %defattr from %files. This is no longer needed. Done > FIX: Your %doc is empty. Include the relevant documentation, e.g. '%doc > Changes LICENSE README'. Done (how could I miss that?) > FIX: Remove all your perl-* explicit Requires. One of the reasons is the one I > mentioned earlier, another is rpmbuild generates those (or most of, nothing's > perfect) automatically, hence you only have to Require those: perl(DateTime) > and perl(XML::LibXML) Done > "FIX" items are blockers. > I see you've also submitted other Perl packages. I'll do the reviews and > sponsor you if you manage to fix everything :) I have updated those packages as well, new links should be in place soon. > Generated by fedora-review 0.1.1 Kind of curious on that tool :) --a New links: spec: http://dl.dropbox.com/u/17870887/perl-Crypt-Blowfish_PP-2/perl-Crypt-Blowfish_PP.spec srpm: http://dl.dropbox.com/u/17870887/perl-Crypt-Blowfish_PP-2/perl-Crypt-Blowfish_PP-1.12-2.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review