Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=598860 --- Comment #15 from Nikos Roussos <nikos@xxxxxxxxxxxxx> 2012-02-21 04:09:30 EST --- (In reply to comment #13) > Actually you're using tabs instead of spaces :) And in some cases you're mixing > them. I believe it is not. Please say on what line and I'll fix it. Rpmlint silent about that. For instance you use tabs on BuildRequires lines but spaces on "if" block at line 79. > You could add build requires dependencies one per line. It's more readable. It then increase size of file which already not so small. I think it is not block. Both this and the above are definitely not blockers. It's just friendly suggestions to make the spec more readable. > Use the full length of a line for description, up to 80 characters. There no lines longer already. I meant the opposite :) Some lines should be longer. For instance the first one on the description block. >> Add some descriptive comments or/and upstream links on patches > It there. I have slightly fix it and add URL on comment. Nice. Please keep track of this in order to update your spec in a future release. I'll do a format review asap. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review