Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=795451 Alexander Kurtakov <akurtako@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |akurtako@xxxxxxxxxx --- Comment #1 from Alexander Kurtakov <akurtako@xxxxxxxxxx> 2012-02-20 11:55:43 EST --- Are you sponsored? If not please block FE-NEEDSPONSOR * It would be good to keep the build.xml as SourceX instead of catting it in the spec. * checks like %if 0%{?suse_version} > 1000 make no sense in fedora, we either need it or not * please install javadocs into %{_javadocdir}/%{name} not in %{_javadocdir}/%{name}-%{version} and drop the symlink/ghost thing * no need for clean section and cleaning in the install section * please use desktop-file-install https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files * where did you get Source0 from ? if it's manually created please either add comments on the exact comments to recreate it or add a script for that as SourceX * I see references to lucene in the spec but it's not BR/R , would you explain? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review