Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=734275 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugzilla.redhat.com | |/show_bug.cgi?id=772608, | |https://bugzilla.redhat.com | |/show_bug.cgi?id=783716, | |https://bugzilla.redhat.com | |/show_bug.cgi?id=786668 | --- Comment #17 from Martin Gieseking <martin.gieseking@xxxxxx> 2012-02-19 09:46:38 EST --- Here's the formal review of your package. There are a couple of things that need to be fixed: - The package currently doesn't build in mock (F16) because of * missing BR: gnutls-devel * clash of "error" macros I suggest to manually expand the macro in file Embedded_Display/vncview.cpp and drop its definition from the same file. This should be reported upstream. - The license of aqemu is GPLv2+ according to the source file headers. => update the License field accordingly - Add a short comment above Patch0 telling what the patch does. Have you sent the patch upstream? - File README contains installation instructions only. => it should be removed from the package - Please add the section suffix to the manpage filename in %files: %{_mandir}/man1/%{name}* => %{_mandir}/man1/%{name}.1* - Add blank lines between the %changelog entries to improve legibility. $ rpmlint *.rpm aqemu.src: W: invalid-url URL: http://aqemu.sourceforge.net HTTP Error 403: Forbidden aqemu.x86_64: W: invalid-url URL: http://aqemu.sourceforge.net HTTP Error 403: Forbidden aqemu.x86_64: E: incorrect-fsf-address /usr/share/doc/aqemu-0.8.2/COPYING aqemu-debuginfo.x86_64: W: invalid-url URL: http://aqemu.sourceforge.net HTTP Error 403: Forbidden 3 packages and 0 specfiles checked; 1 errors, 3 warnings. - the invalid URL messages are false positive - incorrect FSF address has been reported upstream --------------------------------- key: [+] OK [.] OK, not applicable [X] needs work --------------------------------- [+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}. [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license. - GPLv2+ according to boilerplates [X] MUST: The License field in the package spec file must match the actual license. - update the License field accordingly [+] MUST: The file containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source. $ md5sum aqemu-0.8.2.tar.bz2* dcec083f566e0a22df7bfe8e7ca4c593 aqemu-0.8.2.tar.bz2 dcec083f566e0a22df7bfe8e7ca4c593 aqemu-0.8.2.tar.bz2.upstream [+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. [.] MUST: If the package does not successfully compile, build or work on an architecture, ... [X] MUST: All build dependencies must be listed in BuildRequires. [+] MUST: When compiling C, C++, or Fortran files, %{optflags} must be applied. [+] MUST: The spec file MUST handle locales properly. [+] MUST: If a package installs files below %{_datadir}/icons, the icon cache must be updated. [.] MUST: Packages storing shared library files (not just symlinks) must call ldconfig in %post and %postun. [+] MUST: Packages must NOT bundle copies of system libraries. [.] MUST: If the package is designed to be relocatable, ... [+] MUST: A package must own all directories that it creates. [+] MUST: A Fedora package must not list a file more than once in %files. [+] MUST: Permissions on files must be set properly. [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [.] MUST: Large documentation files must go in a -doc subpackage. [+] MUST: Files in %doc must not affect the runtime of the application. [.] MUST: Header files must be in a -devel package. [.] MUST: Static libraries must be in a -static package. [.] MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. [.] MUST: devel packages must require the base package using a fully versioned dependency. [.] MUST: Packages must NOT contain any .la libtool archives. [+] MUST: Packages containing GUI applications must include a %{name}.desktop file [+] MUST: .desktop files must be properly installed with desktop-file-install in the %install section. [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: All filenames in rpm packages must be valid UTF-8. EPEL <= 5 only: [X] MUST: The spec file must contain a valid BuildRoot field. [X] MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot}. [X] MUST: Each package must have a %clean section, which contains rm -rf %{buildroot}. [.] MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' [.] SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [X] SHOULD: All patches should be commented in the spec file [X] SHOULD: The reviewer should test that the package builds in mock. [+] SHOULD: The reviewer should test that the package functions as described. [+] SHOULD: If scriptlets are used, those scriptlets must be sane. [.] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. [.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg. [.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. [+] SHOULD: Your package should contain man pages for binaries/scripts. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review