Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=784359 Volker Fröhlich <volker27@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |volker27@xxxxxx --- Comment #9 from Volker Fröhlich <volker27@xxxxxx> 2012-02-19 06:15:53 EST --- Cmake doesn't need a version restriction. Even if you're going for EL 5, you're having 2.6. Talking about EL 5: As Haïkel already said, if you don't go for EL 5, you don't need the clean section and the rm in the install section. But if you're going for EL 5, you need to add a buildroot definition, see: http://fedoraproject.org/wiki/EPEL/FAQ In general, defattr is not necessary anymore, see: http://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions You don't need any of the Requires. RPM is smart enough to figure them out, see: http://fedoraproject.org/wiki/Packaging:Guidelines#Requires Please use the name macro in Source, your cp and in your cmake invocation. The name macro is usually %{name}, not ${name}. Please preserve the timestamp for your copied file (cp -p, for instance), see: http://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps You need a desktop file for graphical applications, see: http://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files Also add license.txt with %doc. The bindir macro is usually %{_bindir}. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review