Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=794783 Xavier Bachelot <xavier@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |xavier@xxxxxxxxxxxx --- Comment #1 from Xavier Bachelot <xavier@xxxxxxxxxxxx> 2012-02-17 13:43:30 EST --- You should use %global rather than %define See https://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define Unless you plan on submitting this for el5, you can remove 'rm -rf $RPM_BUILD_ROOT' at top of %install section, the whole %clean section and the %defattr in the %files section. The BuildRoot can be removed too. See https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean See https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions See https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag The %description could probably be a bit more helpful. You need to file a bug explaining the ExcludeArch. See https://fedoraproject.org/wiki/Packaging:Guidelines#Architecture_Support Apart from that, the spec file looks good. I will build it and check some more stuff after that. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review