Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=791263 --- Comment #2 from Roman Kennke <rkennke@xxxxxxxxxx> 2012-02-16 11:40:28 EST --- > * Instead of having a patch adding the pom, add it as additional Source1 > (direct link to maven repo or wherever) - you can refer to it later as > %{SOURCE1} The problem is that the pom that they upload into the Maven repo lacks 2 dependencies: to ant and to junit (which in this case is not only needed for test scope). That's why I made my own quick pom out of the Maven repository one. Mockito upstream doesn't seem to use Maven themselves. They use ant, and I suppose this would have complicated the build process even more. > * You are not installing license. Both main package and javadoc has to have > %doc LICENSE (and in this case also NOTICE) Fixed. > * Instead of: > cp -p target/mockito-core-1.9.0.jar $RPM_BUILD_ROOT%{_javadir}/%{name}.jar > do: > cp -p target/mockito-core-%{version}.jar $RPM_BUILD_ROOT%{_javadir}/%{name}.jar > It will simplify updates Fixed this and a couple of other places where the version is hardcoded. > * Some upstreams have complicated build systems that add certain files in > special places and then generate something else out of them. It means that if > you build "your way" you can inadvertently introduce changes into final binary > jars. That's why we usually (not always!) prefer to build from SCM over using > source jars. Best way to solve this long term: ask upstream to generate > -project.zip files with complete contents of SCM needed to build. I wouldn't > block a review on this, but I would urge you to be careful. Ugly things have > happened when building like this :-) Yeah true. Maybe I should look into building with upstream's ant instead. Or get them to provide a correct pom somewhere. I updated the above linked files to reflect the changes I made. Thanks, Roman -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review