Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=787293 --- Comment #7 from Nikos Roussos <nikos@xxxxxxxxxxxxx> 2012-02-14 08:05:42 EST --- Hi Pavel, New source files: http://repos.fedorapeople.org/repos/comzeradd/autoverse/fedora-16/SRPMS/sparkleshare-0.8.0-2.fc16.src.rpm http://comzeradd.fedorapeople.org/specs/sparkleshare.spec Some comments: 1. I fixed permission problems 2. > ltmain.sh is part of libtool and bundling does not allowed. True but it's just part of the upstream source file. It's not included on the installed files, so it's not actually bundled. I don't know why they do this, but it's seems like a common practice (even firefox does that). 3. > For what you include: > %global debug_package %{nil} > ? > I think it should be removed. Or just add comment about purposes. Sorry for not adding a comment there. This is needed because of the empty debuginfo package. https://fedoraproject.org/wiki/Packaging:Mono#Empty_debuginfo -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review