Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=657518 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #3 from Petr Pisar <ppisar@xxxxxxxxxx> 2012-02-14 03:56:38 EST --- Spec file changes: --- perl-Net-Amazon-EC2-Metadata.spec.old 2010-11-26 11:22:02.000000000 +0100 +++ perl-Net-Amazon-EC2-Metadata.spec 2012-02-13 18:18:43.000000000 +0100 @@ -1,23 +1,25 @@ Name: perl-Net-Amazon-EC2-Metadata Version: 0.10 -Release: 3%{?dist} +Release: 4%{?dist} Summary: Retrieves data from EC2 Metadata service License: GPL+ or Artistic Group: Development/Libraries URL: http://search.cpan.org/dist/Net-Amazon-EC2-Metadata/ Source0: http://www.cpan.org/authors/id/N/NM/NMCFARL/Net-Amazon-EC2-Metadata-%{version}.tar.gz Patch0: perl-Net-Amazon-EC2-Metadata-0.10-say.patch +# https://rt.cpan.org/Public/Bug/Display.html?id=74949 Patch1: net-amazon-ec2-metadata.diff BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) BuildArch: noarch BuildRequires: perl(LWP::Simple) BuildRequires: perl(Module::Build) BuildRequires: perl(Test::More) -Requires: perl(LWP::Simple) +BuildRequires: perl(Test::Pod) +BuildRequires: perl(Test::Pod::Coverage) Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) %description -This module queries Amazon's Elastic Compute Cloud Metadata service +This module queries Amazon's Elastic Compute Cloud Metadata service. It also fetches 'user_data' which follows the same API but is often no considered part of the metadata service by Amazons documentation. The module also ships with a command line tool ec2meta that provides the same @@ -62,6 +64,9 @@ %changelog +* Mon Feb 13 2012 Lubomir Rintel (GoodData) <lubo.rintel@xxxxxxxxxxxx> 0.10-4 +- Fix issues from review (Petr Pisar, #657518) + * Mon Nov 22 2010 Lubomir Rintel (GoodData) <lubo.rintel@xxxxxxxxxxxx> 0.10-3 - Pull Test::More > TODO: Missing full stop in Description after first sentence. %description -This module queries Amazon's Elastic Compute Cloud Metadata service +This module queries Amazon's Elastic Compute Cloud Metadata service. Ok. > Is the bug report https://bugzilla.gooddata.com/show_bug.cgi?id=4395 > referred from net-amazon-ec2-metadata.diff patch public? The server > requires authentication. +# https://rt.cpan.org/Public/Bug/Display.html?id=74949 Patch1: net-amazon-ec2-metadata.diff Ok. > FIX: BuildRequire perl(Test::Pod) >= 1.14 (t/pod.t:4) > FIX: BuildRequire perl(Test::Pod::Coverage) > 1.04 (t/pod-coverage.t:4) +BuildRequires: perl(Test::Pod) +BuildRequires: perl(Test::Pod::Coverage) Ok. > FIX: Do not Require perl(LWP::Simple) explicitly, it's discovered by rpmbuild. $ rpm -q --requires -p ../RPMS/noarch/perl-Net-Amazon-EC2-Metadata-0.10-4.fc18.noarch.rpm |sort | uniq -c 1 perl(Carp) 1 perl(Data::Dumper) 1 perl(Getopt::Long) 1 perl(LWP::Simple) 1 perl(:MODULE_COMPAT_5.14.2) 1 perl(Net::Amazon::EC2::Metadata) 1 perl(Pod::Usage) 1 perl(strict) 1 perl(vars) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 /usr/bin/perl Binary requires are Ok. $ rpmlint perl-Net-Amazon-EC2-Metadata.spec ../SRPMS/perl-Net-Amazon-EC2-Metadata-0.10-4.fc18.src.rpm ../RPMS/noarch/perl-Net-Amazon-EC2-Metadata-0.10-4.fc18.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint Ok. Package builds in F18 (http://koji.fedoraproject.org/koji/taskinfo?taskID=3789206). Ok. Resolution: Package APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review