Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=784608 Volker Fröhlich <volker27@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |volker27@xxxxxx --- Comment #1 from Volker Fröhlich <volker27@xxxxxx> 2012-02-13 17:36:49 EST --- rm -rf $RPM_BUILD_ROOT is no longer necessary. This package will only build on F17 and up, looking at the version requirements. You don't need to state a version for kdelibs-devel, since it is newer than 4.5 for any version of Fedora. Can you make use of the tests? Desktop files must be validated, please see: http://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage And for the sake of beauty, there's an empty line at the very bottom. ;) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review