Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=788080 --- Comment #2 from Matthias Runge <mrunge@xxxxxxxxxxxxxxxxx> 2012-02-13 06:00:22 EST --- Hi Massimo, thank you for your annotations. * build is only recommended to set rpm-flags on arch-dependent packages. This one is noarch. * there's no specific reason for -O1 on install. It simply comes from rpmdev-newspec (it's a given template). Install does not compile something, but just copies the files into buildroot. * files: section: it's up to the packager, how to handle those files. Being stricter would be cleaner. * man-page: you're right, I'd love to provide man-pages; sadly upstream does not provide man-pages. It's just a *should*, not a *MUST*. applying files-cleanup: @@ -2,7 +2,7 @@ Name: python-xhtml2pdf Version: 0.0.3 -Release: 1%{?dist} +Release: 2%{?dist} Summary: HTML/CSS to PDF converter based on Python # licensed under ASL 2.0 and BSD-License @@ -55,11 +55,15 @@ %files %doc LICENSE.txt README.rst VERSION.txt MANIFEST.in -%{python_sitelib}/* +%{python_sitelib}/%{pkgname}-%{version}-py?.?.egg-info +%{python_sitelib}/%{pkgname}/ %{_bindir}/pisa %{_bindir}/xhtml2pdf %changelog +* Mon Feb 13 2012 Matthias Runge <mrunge@xxxxxxxxxxxxxxxxx> - 0.0.3-2 +- be more explicit in %%files-section + * Tue Feb 07 2012 Matthias Runge <mrunge@xxxxxxxxxxxxxxxxx> - 0.0.3-1 - initial packaging Updated SRPM: http://www.matthias-runge.de/fedora/python-xhtml2pdf-0.0.3-2.fc16.src.rpm Updated SPEC: http://www.matthias-runge.de/fedora/python-xhtml2pdf.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review