Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=789332 --- Comment #4 from Iain Arnell <iarnell@xxxxxxxxx> 2012-02-10 10:25:42 EST --- (In reply to comment #1) > TODO: Use %{_bindir} in git file requirements instead of hardcoded /usr/bin That's an interesting catch. With /usr move, it makes sense to avoid hardcoding paths, but technically, Git-Repository only needs git somewhere in $PATH. How about just {Build,}Requires: git? > TIP: I'd include Changes and README in perl-Test-Git as well; although > those files will be always installed with the base package, I don't think > users will know they should look to the Git::Repository doc directory; > or maybe you could add a special NOTE file with "look over there" to > Test::Git doc? Well perl-Test-Git isn't really for users - it's only sub-packaged to avoid runtime deps on perl(Test::Builder). I'd hope that anyone who really cares about it would already know it's part of Git-Repository - or be able to find it on search.cpan.org. > No actual show stoppers. Approving. Thanks for the review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review