Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=788815 --- Comment #4 from Tim Fenn <tim.fenn@xxxxxxxxx> 2012-02-10 03:21:38 EST --- (In reply to comment #3) > Awesome ! > > i've mistakenly pasted the wrong download url in my review (i'm sorry, it's my > fault), it should be: > http://downloads.sourceforge.net/project/pywebsvcs/ZSI/ZSI-%{version}/ZSI-%{version}.tar.gz > Oh, whoops - I thought I fixed that, apparently I just entered a second, incorrect address! >.< > A quick test: > urlgrabber > http://downloads.sourceforge.net/project/pywebsvcs/ZSI/ZSI-2.0/ZSI-2.0.tar.gz > > The mock build fails due to tests > http://koji.fedoraproject.org/koji/taskinfo?taskID=3777577 > > Since tests doesn't modify their sys.path, they fail to find the ZSI module > (which is not installed yet). To fix that, you can add the ZSI directory to > PYTHONPATH environment variable. PyXML will also be needed as a BR. > I have one more failing tests (the TCtimes one). > > Here's a scratch build of a slightly modified version of your package that > builds inside mock. > http://koji.fedoraproject.org/koji/taskinfo?taskID=3777593 > Great, thanks. Mental note to myself: do mock tests in rawhide next time to find these errors. ;) > As soon as you fix the download url, i'll approve this package. Save that, it's > all green for me. OK, done: Spec URL: https://sites.google.com/site/timfenn/python-ZSI.spec SRPM URL: https://sites.google.com/site/timfenn/python-ZSI-2.0-12.fc16.src.rpm Again, thanks for the help! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review