Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=738556 --- Comment #15 from shrek-m <shrek-m@xxxxxx> 2012-02-09 18:56:37 EST --- Thanks for your work, gogoc-1.2-8 SRPM works great under fc16 :) gogoc-1.2-8.fc16.i686.rpm gogoc-debuginfo-1.2-8.fc16.i686.rpm i have absolutely no knowledge with rpm-packaging :( would it be useful if the radvd-maintainers could be sponsors or co-maintainers, if they have time ? # rpm -q -changelog radvd * Mo Okt 10 2011 Jiri Skala <jskala@xxxxxxxxxx> - 1.8.2-2 - fixes CVE-2011-3602 [...] * Mi Jan 13 2010 Jan Gorig <jgorig@xxxxxxxxxx> - 1.5-1 - updated do latest upstream version - fixed #554125 - added error message [...] ---- gogoc has a radvd dependency ---- [root@macmini ~]# rpm -e --nodeps radvd [root@macmini ~]# LANG=C rpm -Uvh rpmbuild/RPMS/i686/gogoc-1.2-8.fc16.i686.rpm error: Failed dependencies: radvd is needed by gogoc-1.2-8.fc16.i686 oops, is this correct that gogoc has no dependencies in yum if it is installed with rpm ? [root@macmini ~]# LANG=C yum deplist gogoc Loaded plugins: refresh-packagekit, security, upgrade-helper Finding dependencies: [root@macmini ~]# ----/---- ok, no sponsor yet :( if this package would be in "rawhide / testing" what would i do ? rpmsave is only created if gogoc.conf was changed, this is correct. # LANG=C rpm -e gogoc warning: /etc/gogoc/gogoc.conf saved as /etc/gogoc/gogoc.conf.rpmsave a few remarks as a user and admin: 0) a gogoc-package in EPEL with an additional SysV init script for RHEL5 would be ok until 2017/2020 RHEL6 would be ok until 2020/2023 RHEL7 should have systemd too ?! http://en.wikipedia.org/wiki/Red_Hat_Enterprise_Linux 1) my understanding is that you should add "gcc-c++" ? BuildRequires: kernel-headers, openssl-devel, systemd-units, gcc-c++ ---- gcc-c++ was not installed on my fc16 ---- make[1]: Leaving directory `/root/rpmbuild/BUILD/gogoc-1.2/gogoc-1_2-RELEASE/gogoc-pal' Building gogoc-config module ... make[1]: Entering directory `/root/rpmbuild/BUILD/gogoc-1.2/gogoc-1_2-RELEASE/gogoc-config' mkdir -p objs g++ -O2 -I. -I../gogoc-pal/out_inc -I../gogoc-pal/defs -Wall -D_REENTRANT -DNDEBUG -c -o objs/namevalueparser.o src/namevalueparser.cc make[1]: g++: Command not found make[1]: *** [objs/namevalueparser.o] Error 127 make[1]: Leaving directory `/root/rpmbuild/BUILD/gogoc-1.2/gogoc-1_2-RELEASE/gogoc-config' make: *** [check-gogoc-config] Error 2 error: Bad exit status from /var/tmp/rpm-tmp.jfjLA8 (%build) ----/---- # yum list gcc* # yum install -y gcc-c++ and rpmbuild is ok. 2) oops, debian-patches (why?) in the changelog but not in SOURCES ? or is this i.e. the "lp418176_client_v4.patch" ? "Author: Philippe Gauthier <philippe.gauthier@xxxxxxxxx> Description: Fix crash on 64-bit architectures occuring when the client_v4 option is not set to "auto"." [root@macmini ~]# rpm -q --changelog gogoc * Di Sep 20 2011 Juan Orti Alcaine <j.orti.alcaine@xxxxxxxxx> - 1.2-8 - fixed debug symbols * Mo Sep 19 2011 Juan Orti Alcaine <j.orti.alcaine@xxxxxxxxx> - 1.2-7 - spec file clean up - systemd service fix * Mi Sep 14 2011 Juan Orti Alcaine <j.orti.alcaine@xxxxxxxxx> - 1.2-6 - add Debian patches - add systemd service - license changed to BSD [root@macmini ~]# ls rpmbuild/SOURCES gogoc-1.2-debug_info.patch gogoc-1.2-dirpath.patch gogoc-1.2-gcc_4.6_compile_fix.patch gogoc-1.2-gogoc_conf_5.patch gogoc-1.2-kill_radvd.patch gogoc-1.2-lp418176_client_v4.patch gogoc-1.2-mkdir.patch gogoc-1_2-RELEASE.tar.gz gogoc-1.2-selinux_fix.patch gogoc.service 3) - i do not know if this is the correct place for samples but it would be great if you could move the original "gogoc.conf.sample" into /usr/share/doc/gogoc-1.2/ it is always useful if a admin should need a new /etc/gogoc/gogoc.conf ;) - i do not know if the linux.sh should be under /etc/gogoc/template/ or under /usr/share/doc/gogoc-1.2/ a) your rpm file list [root@macmini ~]# rpm -ql gogoc /etc/gogoc /etc/gogoc/gogoc.conf /etc/gogoc/template /etc/gogoc/template/linux.sh /etc/sysconfig/gogoc /lib/systemd/system/gogoc.service /usr/bin/gogoc /usr/share/doc/gogoc-1.2 /usr/share/doc/gogoc-1.2/CLIENT-LICENSE.TXT /usr/share/doc/gogoc-1.2/README /usr/share/gogoc /usr/share/gogoc/template /usr/share/gogoc/template/README /usr/share/gogoc/template/linux.sh /usr/share/man/man5/gogoc.conf.5.gz /usr/share/man/man8/gogoc.8.gz /var/lib/gogoc /var/lib/gogoc/gogockeys.pub /var/lib/gogoc/tsp-broker-list.txt /var/lib/gogoc/tsp-last-server.txt /var/log/gogoc /var/run/gogoc /var/run/gogoc/gogoc-rtadvd.conf b) vs. gogo6-sourcecode - `make` [root@srv01 ~]# ls /usr/local/gogoc/ /usr/local/gogoc/bin/ /usr/local/gogoc/man/ /usr/local/gogoc/template/ /usr/local/gogoc/: bin gogoc-rtadvd.conf man template /usr/local/gogoc/bin/: gogoc gogoc.conf.sample tsp-broker-list.txt gogoc.conf gogockeys.pub tsp-last-server.txt /usr/local/gogoc/man/: man5 man8 /usr/local/gogoc/template/: linux.sh README 4) CAP_SYS_MODULE (deprecated) i do not know if the warnings in /var/log/messages are a gogoc problem or fc16 / slel6.2 related. the source md5sums are identical, it occurs on both systems everytime i start `gogoc` a) FC16 - `rpmbuild` from your SRPM 41177ed683cf511cc206c7782c37baa9 gogoc-1_2-RELEASE.tar.gz # rpm -q gogoc gogoc-1.2-8.fc16.i686 /var/log/messages Feb 9 20:51:07 macmini kernel: : [ 3359.445191] Loading kernel module for a network device with CAP_SYS_MODULE (deprecated). Use CAP_NET_ADMIN and alias netdev-tun instead b) SLEL6.2 - `make` source from gogo6.net 41177ed683cf511cc206c7782c37baa9 gogoc-1_2-RELEASE.tar.gz # grep -ir cap_ /root/gogoc-1_2-RELEASE/ /root/gogoc-1_2-RELEASE/gogoc-tsp/include/tsp_cap.h:#ifndef _TSP_CAP_H_ /root/gogoc-1_2-RELEASE/gogoc-tsp/include/tsp_cap.h:#define _TSP_CAP_H_ /var/log/messages Feb 9 16:34:48 srv01 kernel: Loading kernel module for a network device with CAP_SYS_MODULE (deprecated). Use CAP_NET_ADMIN and alias netdev-tun instead -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review