Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=787128 --- Comment #2 from Ian Weller <ian@xxxxxxxxxxxxx> 2012-02-09 16:27:38 EST --- (So there's not any confusion, I asked Jamie to do a full review of this package as part of the sponsorship process.) (In reply to comment #1) > 2) ChangeLog date format usually has leading zero (Fri Feb 03 2012). This is up to the packager; there's no rule in the packaging guidelines about this. (I usually drop the leading zero.) > [x] MUST: rpmlint must be run on the source rpm and all binary rpms the build > produces. The output should be posted in the review. libfep.x86_64: W: no-manual-page-for-binary fep libfep.x86_64: W: no-manual-page-for-binary fepcli libfep-devel.x86_64: W: no-documentation These warnings are all fine. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review