Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755093 Josh Boyer <jwboyer@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #36 from Josh Boyer <jwboyer@xxxxxxxxxx> 2012-02-09 15:28:37 EST --- - Package meets naming and packaging guidelines - Spec file matches base package name. - Spec has consistant macro usage. - Meets Packaging Guidelines. - License GPLv2+ - License field in spec matches - License file included in package - Spec in American English - Spec is legible. - Sources match upstream md5sum: [jwboyer@zod ~]$ wget http://www.codon.org.uk/~mjg59/mactel-boot/mactel-boot-0.9.tar.bz2 --2012-02-09 15:16:59-- http://www.codon.org.uk/~mjg59/mactel-boot/mactel-boot-0.9.tar.bz2 Resolving www.codon.org.uk... 93.93.128.6 Connecting to www.codon.org.uk|93.93.128.6|:80... connected. HTTP request sent, awaiting response... 200 OK Length: 7751 (7.6K) [application/x-bzip2] Saving to: “mactel-boot-0.9.tar.bz2” 100%[======================================>] 7,751 48.8K/s in 0.2s 2012-02-09 15:17:00 (48.8 KB/s) - “mactel-boot-0.9.tar.bz2” saved [7751/7751] [jwboyer@zod ~]$ md5sum mactel-boot-0.9.tar.bz2 c03ba709112ab102d6f75b8028bc3db3 mactel-boot-0.9.tar.bz2 [jwboyer@zod ~]$ md5sum ~/rpmbuild/SOURCES/mactel-boot-0.9.tar.bz2 c03ba709112ab102d6f75b8028bc3db3 /home/jwboyer/rpmbuild/SOURCES/mactel-boot-0.9.tar.bz2 [jwboyer@zod ~]$ - Package correctly uses ExclusiveArch - BuildRequires correct I think you can drop the BR on redhat-lsb here and just use the pre-defined %{fedora} in place of your %{fedora_release} macro - Package has %defattr and permissions on files is good. - Package has a correct %clean section. - Package has correct buildroot - Package is code or permissible content. - Packages %doc files don't affect runtime. - Package compiles and builds on at least one arch. [jwboyer@zod SPECS]$ rpmbuild -ba mactel-boot.spec Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.WMqeg6 + umask 022 + cd /home/jwboyer/rpmbuild/BUILD + LANG=C + export LANG + unset DISPLAY + cd /home/jwboyer/rpmbuild/BUILD + rm -rf mactel-boot-0.9 + /usr/bin/bzip2 -dc /home/jwboyer/rpmbuild/SOURCES/mactel-boot-0.9.tar.bz2 + /bin/tar -xf - + STATUS=0 + '[' 0 -ne 0 ']' + cd mactel-boot-0.9 + /bin/chmod -Rf a+rX,u+w,g-w,o-w . + exit 0 Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.K1EYpT + umask 022 + cd /home/jwboyer/rpmbuild/BUILD + cd mactel-boot-0.9 + LANG=C + export LANG + unset DISPLAY ++ lsb_release -r -s + make 'PRODUCTVERSION=Fedora 16' -j4 sed "s/PRODUCTVERSION/Fedora 16/" SystemVersion.plist.in >SystemVersion.plist cc -g -o hfs-bless bless.c + exit 0 Executing(%install): /bin/sh -e /var/tmp/rpm-tmp.lTpLaH + umask 022 + cd /home/jwboyer/rpmbuild/BUILD + '[' /home/jwboyer/rpmbuild/BUILDROOT/mactel-boot-0.9-1.fc16.x86_64 '!=' / ']' + rm -rf /home/jwboyer/rpmbuild/BUILDROOT/mactel-boot-0.9-1.fc16.x86_64 ++ dirname /home/jwboyer/rpmbuild/BUILDROOT/mactel-boot-0.9-1.fc16.x86_64 + mkdir -p /home/jwboyer/rpmbuild/BUILDROOT + mkdir /home/jwboyer/rpmbuild/BUILDROOT/mactel-boot-0.9-1.fc16.x86_64 + cd mactel-boot-0.9 + LANG=C + export LANG + unset DISPLAY + rm -rf /home/jwboyer/rpmbuild/BUILDROOT/mactel-boot-0.9-1.fc16.x86_64 + make install DESTDIR=/home/jwboyer/rpmbuild/BUILDROOT/mactel-boot-0.9-1.fc16.x86_64 install -D hfs-bless /home/jwboyer/rpmbuild/BUILDROOT/mactel-boot-0.9-1.fc16.x86_64/usr/sbin/hfs-bless install -D -m 644 bless.1 /home/jwboyer/rpmbuild/BUILDROOT/mactel-boot-0.9-1.fc16.x86_64/usr/share/man/man1/hfs-bless.1 + install -D -m 644 SystemVersion.plist /home/jwboyer/rpmbuild/BUILDROOT/mactel-boot-0.9-1.fc16.x86_64/boot/efi/System/Library/CoreServices/SystemVersion.plist + echo 'This file is required for booting' + touch /home/jwboyer/rpmbuild/BUILDROOT/mactel-boot-0.9-1.fc16.x86_64/boot/efi/System/Library/CoreServices/boot.efi + touch /home/jwboyer/rpmbuild/BUILDROOT/mactel-boot-0.9-1.fc16.x86_64/boot/efi/.VolumeIcon.icns + /usr/lib/rpm/find-debuginfo.sh --strict-build-id /home/jwboyer/rpmbuild/BUILD/mactel-boot-0.9 extracting debug info from /home/jwboyer/rpmbuild/BUILDROOT/mactel-boot-0.9-1.fc16.x86_64/usr/sbin/hfs-bless 4 blocks + /usr/lib/rpm/check-buildroot + /usr/lib/rpm/redhat/brp-compress + /usr/lib/rpm/redhat/brp-strip-static-archive /usr/bin/strip + /usr/lib/rpm/brp-python-bytecompile /usr/bin/python 1 + /usr/lib/rpm/redhat/brp-python-hardlink + /usr/lib/rpm/redhat/brp-java-repack-jars Processing files: mactel-boot-0.9-1.fc16.x86_64 Executing(%doc): /bin/sh -e /var/tmp/rpm-tmp.6M0Ctw + umask 022 + cd /home/jwboyer/rpmbuild/BUILD + cd mactel-boot-0.9 + DOCDIR=/home/jwboyer/rpmbuild/BUILDROOT/mactel-boot-0.9-1.fc16.x86_64/usr/share/doc/mactel-boot-0.9 + export DOCDIR + /bin/mkdir -p /home/jwboyer/rpmbuild/BUILDROOT/mactel-boot-0.9-1.fc16.x86_64/usr/share/doc/mactel-boot-0.9 + cp -pr GPL /home/jwboyer/rpmbuild/BUILDROOT/mactel-boot-0.9-1.fc16.x86_64/usr/share/doc/mactel-boot-0.9 + cp -pr Copyright /home/jwboyer/rpmbuild/BUILDROOT/mactel-boot-0.9-1.fc16.x86_64/usr/share/doc/mactel-boot-0.9 + exit 0 Requires(interp): /bin/sh /bin/sh Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 Requires(post): /bin/sh Requires: libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) rtld(GNU_HASH) Processing files: mactel-boot-debuginfo-0.9-1.fc16.x86_64 Checking for unpackaged file(s): /usr/lib/rpm/check-files /home/jwboyer/rpmbuild/BUILDROOT/mactel-boot-0.9-1.fc16.x86_64 Wrote: /home/jwboyer/rpmbuild/SRPMS/mactel-boot-0.9-1.fc16.src.rpm Wrote: /home/jwboyer/rpmbuild/RPMS/x86_64/mactel-boot-0.9-1.fc16.x86_64.rpm Wrote: /home/jwboyer/rpmbuild/RPMS/x86_64/mactel-boot-debuginfo-0.9-1.fc16.x86_64.rpm Executing(%clean): /bin/sh -e /var/tmp/rpm-tmp.GkuXmT + umask 022 + cd /home/jwboyer/rpmbuild/BUILD + cd mactel-boot-0.9 + rm -rf /home/jwboyer/rpmbuild/BUILDROOT/mactel-boot-0.9-1.fc16.x86_64 + exit 0 - Package has no duplicate files in %files. - Package doesn't own any directories other packages own. - No rpmlint output. [jwboyer@zod SPECS]$ rpmlint ../RPMS/x86_64/mactel-boot-0.9-1.fc16.x86_64.rpm mactel-boot.x86_64: W: hidden-file-or-dir /boot/efi/.VolumeIcon.icns mactel-boot.x86_64: W: dangerous-command-in-%post ln 1 packages and 0 specfiles checked; 0 errors, 2 warnings. [jwboyer@zod SPECS]$ rpmlint ../SRPMS/mactel-boot-0.9-1.fc16.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [jwboyer@zod SPECS]$ I think the warnings can be ignored here. - final provides and requires are sane: [jwboyer@zod SPECS]$ rpm -qp --provides ../RPMS/x86_64/mactel-boot-0.9-1.fc16.x86_64.rpm mactel-boot = 0.9-1.fc16 mactel-boot(x86-64) = 0.9-1.fc16 [jwboyer@zod SPECS]$ rpm -qp --requires ../RPMS/x86_64/mactel-boot-0.9-1.fc16.x86_64.rpm /bin/sh /bin/sh coreutils libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rtld(GNU_HASH) rpmlib(PayloadIsXz) <= 5.2-1 [jwboyer@zod SPECS]$ SHOULD Items: - Should build in mock. - Should build on all supported archs - Should function as described. - Should have sane scriptlets. - Should have dist tag - Should package latest version - check for outstanding bugs on package. Issues: 1. I think just cleanup the extraneous BR on redhat-lsb Conditional on that being fixed, this seems pretty straight-forward to me. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review