Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=788815 Haïkel Guémar <karlthered@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |karlthered@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |karlthered@xxxxxxxxx Flag| |fedora-review? --- Comment #1 from Haïkel Guémar <karlthered@xxxxxxxxx> 2012-02-09 14:52:09 EST --- Package Review ============== Key: - = N/A x = Pass ! = Fail ? = Not evaluated ==== Generic ==== [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [!]: MUST Buildroot is not present Note: Buildroot is not needed unless packager plans to package for EPEL5 [x]: MUST Package contains no bundled libraries. [x]: MUST Changelog in prescribed format. [x]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean would be needed if support for EPEL is required [x]: MUST Sources contain only permissible code or content. [!]: MUST Each %files section contains %defattr if rpm < 4.4 Note: defattr(....) present in %files section. This is OK if packaging for EPEL5. Otherwise not needed [x]: MUST Macros in Summary, %description expandable at SRPM build time. [x]: MUST Package requires other packages for directories it uses. [x]: MUST Package uses nothing in %doc for runtime. [x]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf would be needed if support for EPEL5 is required [x]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: MUST License field in the package spec file matches the actual license. [x]: MUST Package consistently uses macros (instead of hard-coded directory names). [x]: MUST Package meets the Packaging Guidelines. [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST Package does not generates any conflict. [x]: MUST Package obeys FHS, except libexecdir and /usr/target. [x]: MUST Package must own all directories that it creates. [x]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [x]: MUST Requires correct, justified where necessary. [!]: MUST Rpmlint output is silent. rpmlint python-ZSI-2.0-10.fc17.noarch.rpm python-ZSI.noarch: W: spelling-error Summary(en_US) Zolera -> Cholera python-ZSI.noarch: W: no-manual-page-for-binary wsdl2dispatch python-ZSI.noarch: W: no-manual-page-for-binary wsdl2py 1 packages and 0 specfiles checked; 0 errors, 3 warnings. rpmlint python-ZSI-2.0-10.fc17.src.rpm python-ZSI.src: W: spelling-error Summary(en_US) Zolera -> Cholera python-ZSI.src: W: invalid-url Source0: http://belnet.dl.sourceforge.net/sourceforge/pywebsvcs/ZSI-2.0.tar.gz <urlopen error timed out> 1 packages and 0 specfiles checked; 0 errors, 2 warnings. [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. /home/haikel/788815/ZSI-2.0.tar.gz : MD5SUM this package : bb706337cafe9e2201b06b1bce71ca0f MD5SUM upstream package : bb706337cafe9e2201b06b1bce71ca0f [x]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: MUST Package contains a SysV-style init script if in need of one. [x]: MUST File names are valid UTF-8. [x]: SHOULD Reviewer should test that the package builds in mock. [-]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x]: SHOULD Package functions as described. [x]: SHOULD Package does not include license text files separate from upstream. [x]: SHOULD SourceX is a working URL. [-]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: SHOULD Package should compile and build into binary rpms on all supported architectures. [-]: SHOULD %check is present and all tests pass. [x]: SHOULD Packages should try to preserve timestamps of original installed files. [x]: SHOULD Spec use %global instead of %define. Note: %define python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib()")} Issues: [!]: MUST Buildroot is not present Note: Buildroot is not needed unless packager plans to package for EPEL5 [!]: MUST Each %files section contains %defattr if rpm < 4.4 Note: defattr(....) present in %files section. This is OK if packaging for EPEL5. Otherwise not needed [!]: MUST Rpmlint output is silent. rpmlint python-ZSI-2.0-10.fc17.noarch.rpm python-ZSI.noarch: W: spelling-error Summary(en_US) Zolera -> Cholera python-ZSI.noarch: W: no-manual-page-for-binary wsdl2dispatch python-ZSI.noarch: W: no-manual-page-for-binary wsdl2py 1 packages and 0 specfiles checked; 0 errors, 3 warnings. rpmlint python-ZSI-2.0-10.fc17.src.rpm python-ZSI.src: W: spelling-error Summary(en_US) Zolera -> Cholera python-ZSI.src: W: invalid-url Source0: http://belnet.dl.sourceforge.net/sourceforge/pywebsvcs/ZSI-2.0.tar.gz <urlopen error timed out> 1 packages and 0 specfiles checked; 0 errors, 2 warnings. Generated by fedora-review 0.1.2 External plugins: Notes: * we can safely ignore rpmlint output since python-ZSI has existing EPEL5 branch, the same for spelling errors. * fix upstream download url (the one in the spec is not working) http://belnet.dl.sourceforge.net/sourceforge/pywebsvcs/ZSI-2.0.tar.gz * prefer macro style over shell style s/$RPM_BUILD_ROOT/%{buildroot}/ * you should ask upstream to include license text in source package (if they still answer) * Though i won't consider this as a blocker, i strongly recommend you to run tests in %check section. All the more important since ZSI upstream is not responsive. For the few tests, that fails, i suggests you that you override tests exit code with "|| :". That will help you monitoring ZSI health state during each release. * i need to confirm that you're ok with the fact that ZSI is not actively maintained by upstream ? That means that you might have to fix by yourself FTBFS ou issues reported by users. As long as you do the required changes above and you confirm that you will maintain it knowing that upstream might not be helpful, i may approve this package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review