[Bug 788995] Review Request: beefy-miracle-kde-theme - Beefy Miracle KDE Theme

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=788995

Radek Novacek <rnovacek@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+

--- Comment #1 from Radek Novacek <rnovacek@xxxxxxxxxx> 2012-02-09 09:59:24 EST ---
Name: ok
License: ok
Source: ok
BRs/Reqs: ok
Macros used consistently: ok
ldconfig: NA
Desktop file validations: NA
Locales: NA
Docs: ok
Devel: NA
Files: ok 
Build: ok
rpmlint: no issues
beefy-miracle-kde-theme.src:59: W: macro-in-comment %{buildroot}
beefy-miracle-kde-theme.src:59: W: macro-in-comment %{_kde4_appsdir}
beefy-miracle-kde-theme.noarch: W: dangling-relative-symlink
/usr/share/kde4/apps/ksplash/Themes/BeefyMiracle/1920x1200/beefy-miracle.png
../../../../../../backgrounds/beefy-miracle/default/wide/beefy-miracle.png
beefy-miracle-kde-theme.noarch: W: dangling-relative-symlink
/usr/share/kde4/apps/ksplash/Themes/BeefyMiracle/2048x1536/beefy-miracle.png
../../../../../../backgrounds/beefy-miracle/default/standard/beefy-miracle.png
beefy-miracle-kde-theme.noarch: W: dangling-relative-symlink
/usr/share/kde4/apps/ksplash/Themes/BeefyMiracle/1280x1024/beefy-miracle.png
../../../../../../backgrounds/beefy-miracle/default/normalish/beefy-miracle.png
beefy-miracle-kde-theme.noarch: W: dangling-relative-symlink
/usr/share/kde4/apps/kdm/themes/BeefyMiracle/system-logo-white.png
../../../../../pixmaps/system-logo-white.png
beefy-miracle-kde-theme.noarch: W: dangling-relative-symlink
/usr/share/kde4/apps/ksplash/Themes/BeefyMiracle/2048x1536/logo.png
../../../../../../pixmaps/system-logo-white.png


There is mistake in condition for Provides, there should be version bump in
"%if 0%{?fedora} > 15" and in the second condition too.

Please correct the version before adding the package to the distribution. No
other issues found, setting fedora-review+.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]