Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770283 --- Comment #26 from Tomasz Torcz <zdzichu@xxxxxx> 2012-02-09 08:08:39 EST --- For -devel %defattr, it was my overlook. But according to http://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions %defattr is not necessary now. For completness, I included it in -8. For systemd unit, I've written this unit myself. "After=syslog.target" is not necessary with F16 and later, the syslog socket is always available now. "Type=" defaults to "simple" if not provided. This with "-f" (foreground) option for daemon makes unit file shorter and simpler. I'll prepare patches for upstream: correcting FSF address in licenses, providing systemd.unit and maybe updated man page from Debian. But this is something not connected with this review. Spec URL: http://ttorcz.fedorapeople.org/uptimed.spec SRPM URL: http://ttorcz.fedorapeople.org/uptimed-0.3.16-8.fc16.src.rpm Scratch : http://koji.fedoraproject.org/koji/taskinfo?taskID=3774940 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review