Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=788006 Michel Alexandre Salim <michel+fdr@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #2 from Michel Alexandre Salim <michel+fdr@xxxxxxxxxxxx> 2012-02-08 11:24:41 EST --- Everything looks good; APPROVED * DONE Review [100%] - [X] Names [2/2] - [X] Package name - [X] Spec name - [X] Package version [2/2] http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Package_Versioning - [X] Version number http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Version_Tag - [X] Release tag http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Release_Tag http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Pre-Release_packages - [X] Meets [[http://fedoraproject.org/wiki/Packaging/Guidelines][guidelines]] - [X] Source files match upstream b47b3db33766621927b577b53c1451c73af9448c temporary-1.1.2.3.tar.gz b47b3db33766621927b577b53c1451c73af9448c ../SOURCES/temporary-1.1.2.3.tar.gz - [X] [[http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries][No bundled libraries]] - [X] License [4/4] - [X] License is Fedora-approved - [X] No licensing conflict - [X] License field accurate - [X] License included iff packaged by upstream - [X] rpmlint [2/2] - [X] on src.rpm ghc-temporary.src: W: spelling-error %description -l en_US unixutils -> uninstalls ==> ignore this; false positive - [X] on x86_64.rpm ghc-temporary.x86_64: W: spelling-error %description -l en_US unixutils -> uninstalls ghc-temporary-devel.x86_64: W: spelling-error %description -l en_US unixutils -> uninstalls => likewise - [X] Language & locale [2/2] - [X] Spec in US English - [X] Spec legible - [X] Build [3/3] - [X] Koji results Rawhide: as posted by Jens F16: http://koji.fedoraproject.org/koji/taskinfo?taskID=3772605 - [X] BRs complete - [X] Directory ownership - [X] Spec inspection [6/6] - [X] No duplicate files - [X] File permissions - [X] Filenames must be UTF-8 - [X] Macro usage consistent - [X] Documentation [2/2] - [X] If large docs, separate -doc - [X] %doc files are non-essential - [X] Development [2/2] - [X] Headers in -devel - [X] -devel, -static requires main -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review