[Bug 786359] Review Request: PyMunin - Python Module for developing Munin Multigraph Monitoring Plugins

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=786359

--- Comment #4 from Matthias Runge <mrunge@xxxxxxxxxxxxxxxxx> 2012-02-08 02:47:19 EST ---
Thank you for the review.

You're right, I adjusted inconsistent macro usage, see below.

[mrunge@mrungexp SPECS]$ diff -u PyMunin.spec.1 PyMunin.spec
--- PyMunin.spec.1 2012-02-08 08:40:33.060424490 +0100
+++ PyMunin.spec 2012-02-08 08:42:54.211424885 +0100
@@ -1,6 +1,6 @@
 Name:           PyMunin
 Version:        0.9.4
-Release:        1%{?dist}
+Release:        2%{?dist}
 Summary:        Python Module for developing Munin Multigraph Monitoring
Plugins

 License:        GPLv3+
@@ -38,7 +38,7 @@
 # create munin-plugindir
 %{__mkdir} -p %{buildroot}/%{_datarootdir}/munin/plugins

-%{__python} setup.py install -O1 --skip-build --root $RPM_BUILD_ROOT
--prefix=/usr
+%{__python} setup.py install -O1 --skip-build --root %{buildroot}
--prefix=/usr

 # /usr/bin is created by setup.py. remove it, we don't need it. 
 rm -r %{buildroot}/%{_bindir}
@@ -49,6 +49,9 @@
 %{_datarootdir}/munin/plugins/*

 %changelog
+* Wed Feb 08 2012 Matthias Runge <mrunge@xxxxxxxxxxxxxxxxx> - 0.9.4-2
+- use macros consistently
+
 * Thu Feb 02 2012 Matthias Runge <mrunge@xxxxxxxxxxxxxxxxx> - 0.9.4-1
 - fix for netstat-call from upstream



Updated files are here
SRPM: http://www.matthias-runge.de/fedora/PyMunin-0.9.4-2.fc16.src.rpm
SPEC: http://www.matthias-runge.de/fedora/PyMunin.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]