Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=787364 --- Comment #2 from Pierre Dorbais <pierre.dorbais@xxxxxxx> 2012-02-07 12:57:44 EST --- (In reply to comment #1) > I'm not a packager, so I can't be a sponsor yet. > Some comments though: > > 1. LICENSE is missing, you should contact upstream so a LICENSE text will be > included in source tarball There is a "licence.odt" file, do the package must have plain text file ? > 2. The %defattr(-,root,root,-) entry is not needed in Fedora, unless you're > packaging for EPEL5. > > 3. Same for the "rm -rf RPM_BUILD_ROOT" in the beginning of %install OK I'll delete these lines. > 4. Why do you need the .desktop file as a source? I've written and added the .desktop file because -> MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation. Thank you. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review