Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=786668 --- Comment #2 from Ian Weller <ian@xxxxxxxxxxxxx> 2012-02-07 11:31:18 EST --- > I'm not a packager, so I can't be a sponsor yet. I don't need a sponsor, just a reviewer :) > Some comments though: > 1. You're missing two BuildRequires needed for python packages: > a. python2-devel > b. python-setuptools-devel Where does it say I need these? python-devel provides python2-devel, and python-setuptools provides python-setuptools-devel. > 2. A package shouldn't run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the > beginning of %install. (unless you're going to support EPEL5) This is habit for me and it's in rpmdev-newspec. If you can find the rule where it says "do not do this under any circumstances" I will remove it. > 3. The %python_sitelib defenition is not needed in fedora Once again, rpmdev-newspec, please find where it says I must remove it. If there's another problem with the package I might adjust 2 and 3 but I have no interest in bumping an RPM release to fix nothing :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review