[Bug 787564] Review Request: fonts-tweak-tool - a GUI tool for customizing fonts per language on desktops using fontconfig.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=787564

--- Comment #6 from Mohamed El Morabity <pikachu.2014@xxxxxxxxx> 2012-02-07 09:29:37 EST ---
One more comment:
   %install
   %{__python} setup.py install --skip-build --root $RPM_BUILD_ROOT
   desktop-file-install --dir=%{buildroot}%{_datadir}/applications
fonts-tweak-tool.desktop
You should use $RPM_BUILD_ROOT *or* %{buildroot} in all your .spec file, not
the two styles at the same time:
  
http://fedoraproject.org/wiki/Packaging:Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS

About the license change: there's no problem here to switch to GPL to LGPL, but
I just wonder what motivated such a radical choice.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]