Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=787858 Ofer Schreiber <oschreib@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oschreib@xxxxxxxxxx --- Comment #1 from Ofer Schreiber <oschreib@xxxxxxxxxx> 2012-02-07 03:44:07 EST --- I'm not a packager, so I can't be a sponsor yet. Some comments though: 1. BuildRoot is no longer needed in Fedora. should be removed. 2. %clean section is not needed in Fedora, should be removed. 3. The %install section should not contain anything that removes the buildroot. 4. LICENSE is missing, you should contact upstream (well, probably yourself) so a LICENSE text will be included in source tarball. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review