[Bug 784156] Review Request: uwsgi - Fast, self-healing, application container server

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=784156

--- Comment #8 from Jorge A Gallegos <kad@xxxxxxxxx> 2012-02-07 01:38:48 EST ---
(In reply to comment #6)
> Gal,
> 
> Regarding ldconfig in %post section:
> 
> From guidelines:
> 
> Whenever possible (and feasible), Fedora Packages containing libraries should
> build them as shared libraries. In addition, every binary RPM package which
> contains shared library files (not just symlinks) in any of the dynamic
> linker's default paths
> 
> The key determinate on ldconfig being run in %post section is if the shared
> object is in the default linker paths.
> 
> From man ldconfig:
> 
>  ldconfig creates the necessary links  and  cache  to  the  most  recent
>        shared  libraries  found  in  the  directories specified on the command
>        line, in the file /etc/ld.so.conf, and in the trusted directories (/lib
>        and  /usr/lib).  The cache is used by the run-time linker, ld.so or ld-
>        linux.so.  ldconfig checks the header and filenames of the libraries it
>        encounters  when  determining  which  versions  should have their links
>        updated.

Thanks for the feedback, I just fixed the unstripped-binary-or-object warning,
according to
http://fedoraproject.org/wiki/Common_Rpmlint_issues#unstripped-binary-or-object
"Solution:- Make sure binaries are executable." - So I basically just made all
.so files 0755. This warning does not appear anymore

Updated SPEC is http://kad.fedorapeople.org/packages/uwsgi/uwsgi.spec
Updated SRPM is
http://kad.fedorapeople.org/packages/uwsgi/uwsgi-1.0.2.1-2.fc16.src.rpm
You can check the changes to the spec at
https://gist.github.com/629491ed695cc4004831 and the koji scratch build results
at http://koji.fedoraproject.org/koji/taskinfo?taskID=3768034

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]