Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=784944 nucleo <alekcejk@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |alekcejk@xxxxxxxxxxxxxx QAContact|extras-qa@xxxxxxxxxxxxxxxxx |alekcejk@xxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #1 from nucleo <alekcejk@xxxxxxxxxxxxxx> 2012-02-06 22:19:22 EST --- name: ok summary: ok license: ok handling locale files: ok Obsoletes/Provides: ok BuildRequires: telepathy-qt4-deve not needed because ktp-common-internals-devel requires it. "rm -f %{buildroot}%{_kde4_libdir}/libkcmtelepathyaccounts.so" is actually not removes anything. Maybe it should be "rm -f %{buildroot}%{_kde4_libdir}/ libktpaccountskcminternal.so" and remove %{_kde4_libdir}/libktpaccountskcminternal.so? ldd shows that libs installed in kde4 requires only versioned libktpaccountskcminternal.so.4. This will fix rpmlint warning: ktp-accounts-kcm.i686: W: devel-file-in-non-devel-package /usr/lib/libktpaccountskcminternal.so More detailed description can be added from README. There are many protocol dependencies: Requires: telepathy-butterfly Requires: telepathy-gabble Requires: telepathy-haze Requires: telepathy-idle Requires: telepathy-rakia Requires: telepathy-salut Requires: telepathy-sunshine So maybe it makes sense to place every protocol in subpackage with corresponding dependency? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review