Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=672221 Michel Alexandre Salim <michel+fdr@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #2 from Michel Alexandre Salim <michel+fdr@xxxxxxxxxxxx> 2012-02-04 11:42:40 EST --- Almost everything looks good (typo on the comment for BuildRoot: still, not steel). APPROVED. Note that I've tested installing the built package but not actually doing a conversion -- I have no XBase/FoxPro sample tables at hand. updated URLs: spec: http://hubbitus.info/rpm/Fedora13/sqlite3-dbf/sqlite3-dbf.spec SRPM: http://hubbitus.info/rpm/Fedora13/sqlite3-dbf/sqlite3-dbf-2011.01.24-1.fc13.src.rpm #+TODO: TODO(t) WAIT(w@/!) FAIL(f@) | DONE(d) N/A(n) * TODO Review [90%] - [X] Names [2/2] - [X] Package name - [X] Spec name - [X] Package version [2/2] http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Package_Versioning - [X] Version number http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Version_Tag - [X] Release tag http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Release_Tag http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Pre-Release_packages - [X] Meets [[http://fedoraproject.org/wiki/Packaging/Guidelines][guidelines]] - [X] Source files match upstream ✗ sha1sum sqlite3-dbf_2011.01.24.tar.gz ../SOURCES/sqlite3-dbf_2011.01.24.tar.gz 3081deeff2572579a6ccab765c3c8288f1dbba97 sqlite3-dbf_2011.01.24.tar.gz 3081deeff2572579a6ccab765c3c8288f1dbba97 ../SOURCES/sqlite3-dbf_2011.01.24.tar.gz - [X] [[http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries][No bundled libraries]] - [X] License [4/4] - [X] License is Fedora-approved - [X] No licensing conflict - [X] License field accurate - [X] License included iff packaged by upstream - [X] rpmlint [2/2] - [X] on src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. - [X] on x86_64.rpm sqlite3-dbf.x86_64: W: no-manual-page-for-binary sqlite3-dbf 2 packages and 0 specfiles checked; 0 errors, 1 warnings. - [-] Language & locale [1/2] - [ ] Spec in US English in comment for BuildRoot, s|Steel|Still| - [X] Spec legible - [X] Build [3/3] - [X] Koji results http://koji.fedoraproject.org/koji/taskinfo?taskID=3762444 - [X] BRs complete - [X] Directory ownership - [X] Spec inspection [7/7] - [X] No duplicate files - [X] File permissions - [X] Filenames must be UTF-8 - [X] [RHEL] %clean section https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean) - [X] [RHEL 5] %buildroot cleaned on %install - [X] Macro usage consistent - [X] Documentation [1/1] - [X] %doc files are non-essential -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review