[Bug 786808] Review Request: rubygem-ammeter - Write specs for your Rails 3+ generators

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=786808

--- Comment #2 from Vít Ondruch <vondruch@xxxxxxxxxx> 2012-02-02 11:13:52 EST ---
* Move features into -doc
 - If I am not mistaken, the '%{gem_instdir}/features' folder should be moved
   into -doc, since it is cucumber test suite.

* Please consider moving of Gemfile and .gemspec into -doc
  - Not sure if it is not better to preserve such files, although there are
    no guidelines for such files.

* rpmlint

  rubygem-ammeter.noarch: W: hidden-file-or-dir /usr/share/gems/gems/ammeter-
      0.2.2/lib/.DS_Store

  - Please remove the specified file. Is is OS X specific file, not needed for
    Fedora

* Please fix the .gemspec file.
  - The gemspec needs to be update (see rspec-rails gem).
  - When requiring the library, following error appears:

Gem::LoadError: Could not find rspec (>= 2.2) amongst [abstract-1.0.0,
actionpack-3.0.11, activemodel-3.0.11, activesupport-3.0.11, ammeter-0.2.2,
bigdecimal-1.1.0, builder-2.1.2, diff-lcs-1.1.2, erubis-2.6.6, i18n-0.5.0,
io-console-0.3, minitest-2.10.1, rack-1.4.0, rack-mount-0.7.1, rack-test-0.6.0,
railties-3.0.11, rake-0.9.2.2, rdoc-3.9.4, regin-0.3.8, rspec-core-2.8.0,
rspec-expectations-2.8.0, rspec-mocks-2.8.0, rspec-rails-2.8.1,
ruby2ruby-1.2.4, ruby_parser-2.0.4, sexp_processor-3.0.4, thor-0.14.6,
tzinfo-0.3.30]
 from /usr/share/rubygems/rubygems/dependency.rb:247:in `to_specs'
 from /usr/share/rubygems/rubygems/specification.rb:771:in `block in
activate_dependencies'
 from /usr/share/rubygems/rubygems/specification.rb:760:in `each'
 from /usr/share/rubygems/rubygems/specification.rb:760:in
`activate_dependencies'
 from /usr/share/rubygems/rubygems/specification.rb:744:in `activate'
 from /usr/share/rubygems/rubygems.rb:209:in `rescue in try_activate'
 from /usr/share/rubygems/rubygems.rb:206:in `try_activate'
 from /usr/share/rubygems/rubygems/custom_require.rb:58:in `rescue in require'
 from /usr/share/rubygems/rubygems/custom_require.rb:35:in `require'
 from (irb):1
 from /usr/bin/irb:12:in `<main>'

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]