Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=630822 Toshio Kuratomi <tkuratom@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |a.badger@xxxxxxxxx Flag| |fedora-review? --- Comment #4 from Toshio Kuratomi <tkuratom@xxxxxxxxxx> 2012-02-01 18:47:48 EST --- Good: * Named according to the naming guidelines * Spec file named appropriately * License field matches upstream and is an approved open source license * license text included * Spec is legible * tarball matches with upstream * Compiles and builds in koji f16 * No locale files * Not an ELF library * No bundled libraries * Not relocatable * No duplicate files * Permissions set appropriately * Macros used consistently * Code, not content * No large doc files * No %doc files affect the package at runtime * Not a GUI application * Does not own files and directories owned by other packages * All filenames valid utf-8 * Tested that /usr/bin/ansi2html will successfully convert ansi escape sequences into an html document * No scriptlets Needswork: * There's a testsuite so should run that in a %check section:: BuildRequires: python-nose [...] %check python setup.py test * Unowned directory: %{python_sitelib}/%{srcname}/ You have some choices about how to fix this. You could add:: %dir %{python_sitelib}/%{srcname}/ or you could let rpm recursively include things:: %files %defattr(-,root,root,-) %doc LICENSE README.rst %dir %{python_sitelib}/%{srcname}*.egg-info %{python_sitelib}/%{srcname}*.egg-info/* %{python_sitelib}/%{srcname}/ %{_bindir}/ansi2html or even more succinctly:: %files %defattr(-,root,root,-) %doc LICENSE README.rst %{python_sitelib}/* %{_bindir}/ansi2html Up to you which style to prefer. rpmlint output: - python-ansi2html.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/ansi2html/ansi2html.py The FSF address has changed: http://www.fsf.org/about/contact/ Since you're upstream, you can change this in upstream's git and it will be reflected in our package on the next upstream release. - python-ansi2html.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ansi2html/style.py 0644L /usr/bin/env This is because the style.py file has a shebang line: #!/usr/bin/env python Looking at the file, it can't be executed as a script so the shebang line should be removed. - python-ansi2html.noarch: W: no-manual-page-for-binary ansi2html This is a warning only. if you want to write a man page for this, great. If not, it's recommended but not required. Of these, only the shebang removal needs to be done now. Non-blocking: * Not a huge deal but since you're upstream, I had to hunt to find that style.py was the file that made the project GPLv3+. Everything else is licensed under "any version of the GPL". You could mention that it is GPLv3+ in the README.rst or something. * If you're planning on building for EPEL5, you'll need to get multiprocessing reviewed (multiprocessing is built into python-2.6+ so EPEL6 and all non-EOL Fedora are okay). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review