[Bug 670915] Review Request: aprsg - Amateur Radio APRS Gateway

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=670915

--- Comment #6 from Andrew Elwell <andrew.elwell@xxxxxxxxx> 2012-02-01 06:48:01 EST ---
OK - with the gcc-4.7 cleanup I had to explicitly #include <unistd.h> in 
serialport.cpp -- patch submitted upstream to author, together with discussions
on logrotate etc (I have a logrotate.d/aprsg ready to go, but haven't included
it in this as it doesn't log by default).

Files available at 

http://dl.dropbox.com/u/6594808/Fedora/aprsg-1.4-1.fc16.src.rpm
http://dl.dropbox.com/u/6594808/Fedora/aprsg.logrotate
http://dl.dropbox.com/u/6594808/Fedora/aprsg.spec


RPMlint output:

[aelwell@pcitgtelwell aprsg]$ rpmlint aprsg.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

[aelwell@pcitgtelwell aprsg]$ rpmlint ~/rpmbuild/SRPMS/aprsg-1.4-1.fc16.src.rpm 
aprsg.src: W: spelling-error %description -l en_US soundmodem -> sound modem,
sound-modem, soundness
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

(False positive - soundmodem is the name of the package)

On a built binary (mock, F16-x86_64) I also get wrong-file-end-of-line-encoding
for COPYING -- Text is identical to the GPL -- Should I fix with dos2unix or
get  upstream to change?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]