Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772499 Orcan Ogetbil <oget.fedora@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #3 from Orcan Ogetbil <oget.fedora@xxxxxxxxx> 2012-01-31 20:17:05 EST --- Hi Thibault, thank you for the update. The Requires list is fine now, but you accidentally removed BuildRequires too. As far as I can tell, Requires and BuildRequires should be the same. Moreover they can be further simplified (sorry I missed this in the first pass). "fftw" package itself is not required, but its dependencies "fftw-libs" "fftw-libs-threads" are required. Therefore we can do BuildRequires: numpy fftw-libs fftw-libs-threads python2 Requires: numpy fftw-libs fftw-libs-threads python2 Since this is an easy fix, I am approving the package. Please consider the above before you import. ----------------------------------------------- This package (python-anfft) is APPROVED by oget ----------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review