Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756448 --- Comment #3 from Erik van Pienbroek <erik-fedora@xxxxxxxxxxxxxxx> 2012-01-30 14:24:14 EST --- Apologies for the delay. I forgot about this package review. The srpm currently fails to build on rawhide (with the original mingw.org toolchain) because the patch ftplib-3.1-1-mingw.patch contains a hardcoded reference to i686-w64-mingw32-windres. If you want to make this package compatible with both the mingw.org as well as the mingw-w64 toolchain you can perform these two changes: * Replace 'i686-w64-mingw32-windres' with '$(WINDRES)' in the patch ftplib-3.1-1-mingw.patch * Replace the line 'CC=%{_mingw32_cc} \' in the .spec file with '%{_mingw32_env}' I also noticed that the %files section contains a .def file. These files can be dropped as they aren't interesting for other binaries which want to link against this library -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review