Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=785711 Vít Ondruch <vondruch@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #2 from Vít Ondruch <vondruch@xxxxxxxxxx> 2012-01-30 08:51:46 EST --- * Spec file differences - The spec file you provides differs from the spec file in SRPM. The SRPM version looks better IMO. Please make sure which one you are using. * License - The license file says "same as ruby's". However, the license between Ruby 1.8 and Ruby 1.9, differs. Would you mind to clarify the license with upstream? Otherwise I have no other concerns => APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review