Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=738744 --- Comment #2 from Vít Ondruch <vondruch@xxxxxxxxxx> 2012-01-30 07:52:18 EST --- * Please update the library to upstream version - It seems that there is available 1.3.0 version already. * Duplicated files - README.md is duplicated in main package and -doc subpackage. This should be avoided. Instead of including whole %{geminstdir} in the main package, you should include just the LICENSE file there. * Please consider excluding the cached .gem file - The file has no meaning in Fedora, it is just waste-load. * Test suite - Although the test suite is not embedded in the gem, it is available upstream. It would be nice if you could run it during build time following the guidelines [2] * Please consider updating the package for Ruby 1.9.3 - Since we are in the process of rebuild for Ruby 1.9.3, it would be nice if you can prepare this package according to the new guidelines [1] [1] https://fedoraproject.org/wiki/PackagingDrafts/Ruby [2] https://fedoraproject.org/wiki/PackagingDrafts/Ruby#Test_suite_not_included_in_package -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review