Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717920 --- Comment #2 from Bohuslav Kabrda <bkabrda@xxxxxxxxxx> 2012-01-30 02:37:19 EST --- - Please update to the latest version of gem (currently 1.2.1). - The specfile you provided differs from the specfile in SRPM (just the two comments in %check, but please fix this). - License is MIT, not GPLv2+ or Ruby. - Please consider updating to the new standard of Rubygems packaging for Rawhide with Ruby 1.9.3 [1] (and please build the package with new Ruby, not the old one - use f17-ruby target in Koji). - Otherwise the package looks good, but I'd like to see it once more after it gets updated to the latest version, then I'll gladly approve it. [1] https://fedoraproject.org/wiki/PackagingDrafts/Ruby -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review