[Bug 785432] Review Request: php-horde-Horde-Translation - Horde translation library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=785432

Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora@xxxxxxxxxxxxxxxxx
         Depends on|                            |785424

--- Comment #1 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> 2012-01-29 11:30:00 EST ---
First note:

According to upstream (see package.xml), this requires
php-common >= 5.2.0
php-pear(PEAR) >= 1.7.0
php-pear(pear.horde.org/Horde_Test) >= 1.0.0
php-pear(pear.horde.org/Horde_Test) < 2.0.0

%file must be fixed (as explain in the generated spec)

%{pear_xmldir}/%{name}.xml
%{pear_phpdir}/Horde/Translation
%{pear_phpdir}/Horde/Translation.php
%{pear_testdir}/Horde_Translation
%{pear_phpdir}/Horde will be owned by dependant package (Horde_Test, I think)

A good idea will be to create a macro for the channel and to use it.  Also
verify that the pear_name is used everywhere it could.

It seems Horde_Test is not in the review list.

Can you please try to run provided tests in %check (else add a
comment/explanation on the reason)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]