[Bug 785424] Review Request: php-channel-horde - Adds pear.horde.org channel to PEAR

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=785424

Clint Savage <herlo1@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #4 from Clint Savage <herlo1@xxxxxxxxx> 2012-01-29 06:24:16 EST ---
Oops, meant to do that! :)

I'm approving this with one caveat.

[!]: SHOULD Spec use %global instead of %define.
     Note: %define peardir %(pear config-get php_dir 2> /dev/null || echo
     %{_datadir}/pear) %define pear_xmldir /var/lib/pear

Might be good to change that definition.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]