Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=783015 --- Comment #2 from Jerry James <loganjerry@xxxxxxxxx> 2012-01-28 14:05:45 EST --- (In reply to comment #1) > Please remove the double-space from the descriptions. In my view, those double spaces are correct. They are used by a number of tools, including XEmacs, which I use to edit spec files, to distinguish a period that ends an abbreviation, such as "etc.", from a period that ends a sentence. This is used when reflowing text. > Please make the build verbose by removing the at-signs from $(CC). Done. > Library and binaries end up with 775 permissions, which they shouldn't. Hmmm, that's odd. The permissions came out correct when I built on my desktop machine. I'm not sure how that happened, but I've changed the spec to make sure that it cannot happen in the future. > Don't ship the README, as it contains nothing useful, as far as I can see. It contains the email address where bug reports should be sent, which is the only reason I included it. > I'm a bit worried about the generic names of the files in bindir, but there > seem to be no clashes so far. Me, too. I'll talk with upstream about making them less generic in a future release. New URLs: Spec URL: http://jjames.fedorapeople.org/meataxe/meataxe.spec SRPM URL: http://jjames.fedorapeople.org/meataxe/meataxe-2.4.24-2.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review