Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=784457 --- Comment #1 from Michal Schmidt <mschmidt@xxxxxxxxxx> 2012-01-26 18:54:42 EST --- The package does not build in Rawhide, due to libgee -> libgee06 renaming. It builds in F-16. Review Guidelines: [ok] rpmlint: $ rpmlint /var/lib/mock/fedora-16-x86_64/result/*.rpm systemd-ui.x86_64: W: no-manual-page-for-binary systemd-gnome-ask-password-agent 3 packages and 0 specfiles checked; 0 errors, 1 warnings. [ok] package name [ok] spec name matches package name Packaging Guidelines: [ok] naming [ok] version and release [ok] licensing The tarball contains no license text in its own file. Upstream should want to correct this. [ok] no pre-built binaries [ok] spec legible [ok] all archs supported [ok] fs layout [ok] changelog [ok] tags [ok] BuildRoot is implicit [ok] %clean is implicit [ok] no unnecessary Requires [ok] BuildRequires (build succeeds in mock) [BAD] Summary is good, but %description should be expanded somewhat. [ok] encoding [ok] documentation (one manpage) [ok] compiler flags [ok] debuginfo [ok] devel packages (none) [ok] shared libraries (none) [ok] no static libraries [ok] no duplication of system libraries [ok] no rpath [ok] config files (none) [ok] systemd (no units) [BAD] GUI application has no .desktop file [ok] macros [ok] locale files (none) [ok] parallel make [ok] scriptlets (none) [ok] conditional deps (none) [ok] not a relocatable package [ok] code vs content [ok] file&dir ownership [ok] users&groups (none) [ok] web apps (none) [ok] no conflicts [ok] no kernel modules [ok] nothing under /srv [ok] no bundling [ok] patches (none) [ok] Epoch (none) [ok] symlinks (none) [ok] manpages systemd-gnome-ask-password-agent does not have one, but that's not a blocker. [ok] test suites (none) [ok] tmpfiles.d (none) [ok] renaming/replacing Both Provides: and Obsoletes: systemd-gtk Just remember to increase the declared version. [ok] approved license (GPLv2+) [ok] license matches [ok] American English [ok] upstream source tarball 6f3b2ff28fce99d1fdebda54398b98cc systemd-ui-0.tar.xz [ok] sane file permissions [ok] no *.la -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review