Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=784603 Haïkel Guémar <karlthered@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |karlthered@xxxxxxxxx --- Comment #1 from Haïkel Guémar <karlthered@xxxxxxxxx> 2012-01-25 13:27:41 EST --- Since i'm not a sponsor, i will just do an informal review: * if you don't plan to support EPEL5, remove any reference to BuildRoot cleaning and %defattr * Summary is not very informative (ie: Messaging abstraction for Python) * according PyPI, messaging does support python3, so you should provide a python3 variant (if it's supported upstream, as a reviewer, i consider this is a blocker) * rpmlint is surprisingly silent (not even a single false positive spelling error !) * builds fine inside mock * provided sources checksum match with upstream's * license is OK (Apache 2.0) Except for the python3 variant, it complies with Fedora packaging guidelines. I recommend as a wannabe fedora packager, that you start doing informal reviews to show your future sponsor, that you have a well-understanding of our guidelines and help other reviews to advance. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review