Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=784359 Haïkel Guémar <karlthered@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |karlthered@xxxxxxxxx --- Comment #2 from Haïkel Guémar <karlthered@xxxxxxxxx> 2012-01-24 17:03:40 EST --- Nice tool for working with QPid. Just few advices: * you don't need to require glibc-common as BR (it's already provided in the minimal build chroot) * use the %cmake macro * discrepancies between version field (1.0.0) and changelog (0.1) * does not build under mock (missing BR: cmake >= 2.6.0) * your BR should be qpid-qmf-devel and qpid-cpp-client-devel * either you plan to maintain your package under EL5 and you should handle buildroot cleaning or you don't plan maintaining it under EL5 and should remove the %defattr macro * a typo in your description: "quid" instead of "qpid" * wrong license: license.txt says it's under Apache License 2.0, by the way, GPL alone is not enough (valid values: GPLv{2,3}{,+} etc ...) * i recommand you to check your src.rpm and binary rpm with the rpmlint tool. Building your src.rpm with the mock tool is also a must. Since I assume you're also the upstream maintainer: * you should version your source tarball * you should also add installation bits inside your build system, with cmake something like that: install(TARGET xview RUNTIME DESTINATION bin) * you should also rename your binary upstream (xview will also conflicts in other distro which ships xloadimage) qpid-gbroker might confuse people since it's written Qt4 (people usually expect that software that have "g" in their name to be Gtk+ application) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review