Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=783716 Stephen Gordon <sgordon@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sgordon@xxxxxxxxxx --- Comment #1 from Stephen Gordon <sgordon@xxxxxxxxxx> 2012-01-24 15:32:41 EST --- - Based on previous extensions that have been approved, consider renaming the package to fit the form gnome-shell-extension-*. - The license string is not recognised, see the following for a list of valid values. In this instance you possibly want GPLv2 or GPLv2+. http://fedoraproject.org/wiki/Licensing - Use the %find_lang macro for the locale files: http://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files - This looks like a noarch package but is not marked as such: http://fedoraproject.org/wiki/Common_Rpmlint_issues#no-binary - Consider adding a README: http://fedoraproject.org/wiki/Common_Rpmlint_issues#no-documentation - Consider expanding the %description field, currently it contains less information than the Summary. Full rpmlint output: gmail-notify-ext.x86_64: W: invalid-license GPL2 gmail-notify-ext.x86_64: E: no-binary gmail-notify-ext.x86_64: W: no-documentation gmail-notify-ext.x86_64: W: file-not-in-%lang /usr/share/locale/cs/LC_MESSAGES/gmail_notify.mo gmail-notify-ext.x86_64: W: file-not-in-%lang /usr/share/locale/de/LC_MESSAGES/gmail_notify.mo gmail-notify-ext.x86_64: W: file-not-in-%lang /usr/share/locale/es/LC_MESSAGES/gmail_notify.mo gmail-notify-ext.x86_64: W: file-not-in-%lang /usr/share/locale/fr/LC_MESSAGES/gmail_notify.mo gmail-notify-ext.x86_64: W: file-not-in-%lang /usr/share/locale/gl/LC_MESSAGES/gmail_notify.mo gmail-notify-ext.x86_64: W: file-not-in-%lang /usr/share/locale/hu/LC_MESSAGES/gmail_notify.mo gmail-notify-ext.x86_64: W: file-not-in-%lang /usr/share/locale/it/LC_MESSAGES/gmail_notify.mo gmail-notify-ext.x86_64: W: file-not-in-%lang /usr/share/locale/nl/LC_MESSAGES/gmail_notify.mo gmail-notify-ext.x86_64: W: file-not-in-%lang /usr/share/locale/pl/LC_MESSAGES/gmail_notify.mo gmail-notify-ext.x86_64: W: file-not-in-%lang /usr/share/locale/se/LC_MESSAGES/gmail_notify.mo 1 packages and 0 specfiles checked; 1 errors, 12 warnings. Note I'm not sponsored, so can't take this review request, but addressing the above may help expedite the review process when someone else does. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review