Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=783456 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> 2012-01-24 03:25:18 EST --- Source file is original. Ok. URL and Source0 are alive Ok. Summary verified from lib/URI/Find/Simple.pm. Ok. License verified from lib/URI/Find/Simple.pm. Ok. Description verified from lib/URI/Find/Simple.pm. TODO: Add second paragraph that explains explicitly what this package do. No XS code, noarch BuildArch is Ok. TODO: Build-require `perl(lib)' for tests (t/find.t:3). All tests pass. Ok. $ rpmlint perl-URI-Find-Simple.spec ../SRPMS/perl-URI-Find-Simple-1.03-1.fc17.src.rpm ../RPMS/noarch/perl-URI-Find-Simple-1.03-1.fc17.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-URI-Find-Simple-1.03-1.fc17.noarch.rpm drwxr-xr-x 2 root root 0 Jan 24 09:09 /usr/share/doc/perl-URI-Find-Simple-1.03 -rw-r--r-- 1 root root 325 Oct 25 2010 /usr/share/doc/perl-URI-Find-Simple-1.03/Changes -rw-r--r-- 1 root root 2621 Jan 24 09:09 /usr/share/man/man3/URI::Find::Simple.3pm.gz drwxr-xr-x 2 root root 0 Jan 24 09:09 /usr/share/perl5/vendor_perl/URI drwxr-xr-x 2 root root 0 Jan 24 09:09 /usr/share/perl5/vendor_perl/URI/Find -rw-r--r-- 1 root root 2954 Oct 25 2010 /usr/share/perl5/vendor_perl/URI/Find/Simple.pm File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-URI-Find-Simple-1.03-1.fc17.noarch.rpm | sort | uniq -c 1 perl(Carp) 1 perl(Encode) 1 perl(:MODULE_COMPAT_5.14.2) 1 perl(strict) 1 perl(URI::Find) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-URI-Find-Simple-1.03-1.fc17.noarch.rpm | sort | uniq -c 1 perl(URI::Find::Simple) = 1.03 1 perl-URI-Find-Simple = 1.03-1.fc17 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-URI-Find-Simple-1.03-1.fc17.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F17 (http://koji.fedoraproject.org/koji/taskinfo?taskID=3728154). Ok. Otherwise package is in line with Fedora and Perl packaging guidelines. Please consider fixing all `TODO' items before building this package. Resolution: Package APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review