Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772499 Orcan Ogetbil <oget.fedora@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review? --- Comment #1 from Orcan Ogetbil <oget.fedora@xxxxxxxxx> 2012-01-23 19:54:17 EST --- I reviewed this package and have some remarks about minor issues: * rpmlint says python-anfft.src: W: spelling-error %description -l en_US Accummulated -> Accumulated, Accumulate, Acculturated python-anfft.src: W: spelling-error %description -l en_US dotfile -> dot file, dot-file, docile Please fix the first one. I don't know what a 'dotfile' is. If you do please fix this if necessary. ! The license can be marked as GPLv3+ since the source files have the "or later" clause but this is not a blocker since there is no GPLv4 for the time being. - During the build, I get a warning during %check: + python test.py /builddir/build/BUILD/anfft-0.1/anfft/_fftw.py:260: UserWarning: Can't load wisdom from "/builddir/.anfft" warn("Can't load wisdom from \"%s\"" % basedir) But looking through the source code, this warning seems unimportant. * BuildRequires: numpy fftw-devel python-devel BuildRequires: python-devel is too much. Instead BuildRequires: numpy fftw python2 is sufficient. Note that python-devel was listed twice. Also note that we specify the python version. ! rm -rf %{buildroot} is not required in %install. Does no harm though. ! You can probably use libdir=build/lib in %check (build/lib is what I have on x86_64 too). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review