Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=781775 Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tomspur@xxxxxxxxxxxxxxxxx Flag| |fedora-review+ --- Comment #1 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2012-01-23 18:45:10 EST --- Review: - This looks like a 95% copy of your other reviews, so it will be hard to find a further nitpick ;) - license ok - %files ok - library correctly packaged - doc has own COPYING -> may not depend on main package - %check there - parallel make used - doc is noarch where possible - BuildRoot, rm -rf is there (needed for EL5) - BR ok - source match upstream: c2300b3e8abbea7899261e91a605e982 sevmgr-0.2.0.tar.bz2 - koji build works: http://koji.fedoraproject.org/koji/taskinfo?taskID=3726948 NEEDSWORK: - add license headers ;) ================================================================== APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review