Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772786 Haïkel Guémar <karlthered@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |karlthered@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |karlthered@xxxxxxxxx Flag| |fedora-review? --- Comment #3 from Haïkel Guémar <karlthered@xxxxxxxxx> 2012-01-23 16:11:24 EST --- Package Review ============== Key: - = N/A x = Pass ! = Fail ? = Not evaluated ==== C/C++ ==== [x]: MUST Package does not contain any libtool archives (.la) [x]: MUST Package does not contain kernel modules. [x]: MUST Package contains no static executables. [x]: MUST Rpath absent or only used for internal libs. [x]: MUST Package is not relocatable. ==== Generic ==== [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: MUST Buildroot is not present Note: Unless packager wants to package for EPEL5 this is fine [x]: MUST Package contains no bundled libraries. [x]: MUST Changelog in prescribed format. [x]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean would be needed if support for EPEL is required [x]: MUST Sources contain only permissible code or content. [x]: MUST Each %files section contains %defattr if rpm < 4.4 Note: Note: defattr macros not found. They would be needed for EPEL5 [x]: MUST Macros in Summary, %description expandable at SRPM build time. [x]: MUST Package contains a properly installed %{name}.desktop using desktop- file-install file if it is a GUI application. [x]: MUST Package requires other packages for directories it uses. [x]: MUST Package uses nothing in %doc for runtime. [x]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf would be needed if support for EPEL5 is required [x]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: MUST License field in the package spec file matches the actual license. [x]: MUST Package consistently uses macros (instead of hard-coded directory names). [x]: MUST Package meets the Packaging Guidelines. [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST Package does not generates any conflict. [x]: MUST Package obeys FHS, except libexecdir and /usr/target. [x]: MUST Package must own all directories that it creates. [x]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [x]: MUST Requires correct, justified where necessary. [!]: MUST Rpmlint output is silent. rpmlint converseen-0.4.8-2.fc17.src.rpm converseen.src: W: spelling-error %description -l en_US resizer -> re sizer, re-sizer, resister 1 packages and 0 specfiles checked; 0 errors, 1 warnings. rpmlint converseen-debuginfo-0.4.8-2.fc17.i686.rpm converseen-debuginfo.i686: E: debuginfo-without-sources 1 packages and 0 specfiles checked; 1 errors, 0 warnings. rpmlint converseen-0.4.8-2.fc17.i686.rpm converseen.i686: W: spelling-error %description -l en_US resizer -> re sizer, re-sizer, resister converseen.i686: W: no-manual-page-for-binary converseen 1 packages and 0 specfiles checked; 0 errors, 2 warnings. [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. /home/builder/772786/converseen-0.4.8.tar.bz2 : MD5SUM this package : 65cdb89445a3063b9c8362b411d3e3ef MD5SUM upstream package : 65cdb89445a3063b9c8362b411d3e3ef [x]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: MUST Package contains a SysV-style init script if in need of one. [x]: MUST File names are valid UTF-8. [x]: SHOULD Reviewer should test that the package builds in mock. [-]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x]: SHOULD Package functions as described. [x]: SHOULD Package does not include license text files separate from upstream. [x]: SHOULD SourceX is a working URL. [-]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: SHOULD Package should compile and build into binary rpms on all supported architectures. [-]: SHOULD %check is present and all tests pass. [x]: SHOULD Packages should try to preserve timestamps of original installed files. [x]: SHOULD Spec use %global instead of %define. Issues: [!]: MUST Rpmlint output is silent. rpmlint converseen-0.4.8-2.fc17.src.rpm converseen.src: W: spelling-error %description -l en_US resizer -> re sizer, re-sizer, resister 1 packages and 0 specfiles checked; 0 errors, 1 warnings. rpmlint converseen-debuginfo-0.4.8-2.fc17.i686.rpm converseen-debuginfo.i686: E: debuginfo-without-sources 1 packages and 0 specfiles checked; 1 errors, 0 warnings. rpmlint converseen-0.4.8-2.fc17.i686.rpm converseen.i686: W: spelling-error %description -l en_US resizer -> re sizer, re-sizer, resister converseen.i686: W: no-manual-page-for-binary converseen 1 packages and 0 specfiles checked; 0 errors, 2 warnings. Generated by fedora-review 0.1.2 External plugins: comments: * licensed under GPLv3 * globally respect fedora packaging guidelines * package installs and is working (though it does leak memory, you should suggest the maintainer to fix his package using valgrind) * the usual rpmlint spelling nagging (false positive), you should request maintainer to provide a manual page (not a blocker) * you should use the %cmake macro (since it is a specific cmake guideline, i will block this package until it is fixed), besides you won't have to set prefix by hand. Summary: As soon as you replace the call to cmake by %cmake, i will approve this package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review